Add job and instance as well-known labels in prometheus receiver #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
force-pushed
the
prometheus_receiver
branch
from
e6f1024 to
213e1be
Compare
Codecov Report
@@ Coverage Diff @@
## main #2897 +/- ##
=======================================
Coverage 91.74% 91.74%
=======================================
Files 286 286
Lines 15086 15088 +2
=======================================
+ Hits 13841 13843 +2
Misses 851 851
Partials 394 394
Continue to review full report at Codecov.
|
rakyll
approved these changes
Apr 13, 2021
carlosalberto
approved these changes
Apr 13, 2021
dashpole
approved these changes
Apr 14, 2021
Aneurysm9
approved these changes
Apr 14, 2021
jrcamp
approved these changes
Apr 16, 2021
|
@bjrara which of the linked issues are fully resolved by this PR? |
|
#2964 should address this issue. |
This was referenced Apr 21, 2021
bogdandrutu
pushed a commit
that referenced
this pull request
Apr 22, 2021
…orter (#2979) This is a follow up to #2897. Fixes #575 Fixes #2499 Fixes #2363 Fixes open-telemetry/prometheus-interoperability-spec#37 Fixes open-telemetry/prometheus-interoperability-spec#39 Fixes open-telemetry/prometheus-interoperability-spec#44 Passing compliance tests: $ go test --tags=compliance -run "TestRemoteWrite/otelcollector/Job.+" -v ./ === RUN TestRemoteWrite === RUN TestRemoteWrite/otelcollector === RUN TestRemoteWrite/otelcollector/JobLabel === PAUSE TestRemoteWrite/otelcollector/JobLabel === CONT TestRemoteWrite/otelcollector/JobLabel --- PASS: TestRemoteWrite (10.02s) --- PASS: TestRemoteWrite/otelcollector (0.00s) --- PASS: TestRemoteWrite/otelcollector/JobLabel (10.02s) PASS ok github.com/prometheus/compliance/remote_write 10.382s $ go test --tags=compliance -run "TestRemoteWrite/otelcollector/Instance.+" -v ./ === RUN TestRemoteWrite === RUN TestRemoteWrite/otelcollector === RUN TestRemoteWrite/otelcollector/InstanceLabel === PAUSE TestRemoteWrite/otelcollector/InstanceLabel === CONT TestRemoteWrite/otelcollector/InstanceLabel --- PASS: TestRemoteWrite (10.01s) --- PASS: TestRemoteWrite/otelcollector (0.00s) --- PASS: TestRemoteWrite/otelcollector/InstanceLabel (10.01s) PASS ok github.com/prometheus/compliance/remote_write 10.291s $ go test --tags=compliance -run "TestRemoteWrite/otelcollector/RepeatedLabels.+" -v ./ === RUN TestRemoteWrite === RUN TestRemoteWrite/otelcollector --- PASS: TestRemoteWrite (0.00s) --- PASS: TestRemoteWrite/otelcollector (0.00s) testing: warning: no tests to run PASS
|
After this PR was merged, I still don't see instance and job labels |
|
I'm using version 0.55.0 and I still don't see instance and job labels. |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…x-agent (open-telemetry#2897) * Bump github.com/hashicorp/vault in /pkg/signalfx-agent Bumps [github.com/hashicorp/vault](https://github.com/hashicorp/vault) from 1.12.2 to 1.12.5. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v1.12.2...v1.12.5) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * tidy --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Antoine Toulme <atoulme@splunk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Prometheus,
jobandinstanceare the two auto generated labels, however they are both dropped by prometheus receiver. Although these information is still available inservice.nameandhost:port, it breaks the data contract for most Prometheus users (who usejobandinstanceto consume metrics in their own system).This PR adds
jobandinstanceas well-known labels in prometheus receiver to fix the issue.Link to tracking Issue:
#575
#2499
#2363
open-telemetry/prometheus-interoperability-spec#7